fix(react-native-cli): ensure kotlin files are updated #2092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Builds on #2091 to ensure that the React Native CLI updates native Android files correctly in React Native 0.73 projects.
The previous PR updated the file lookup to find
MainApplication.kt
files as well asMainApplication.java
, but the subsequent update still fails as it was still looking for java code snippets.In addition, the CLI was still suggesting BAGP version
7.+
for RN 0.73, but should be suggesting8.+
Design
MainApplication.kt
filesgetSuggestedBugsnagGradleVersion
now attempts to suggests a version based on the detected React Native version when the AGP version is not found in the Gradle file (recent versions of React Native do not explicitly set the AGP version in the rootbuild.gradle
file)Testing
Added unit test cases and tested manually on fresh RN 0.71, 0.72 and 0.73 projects