Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-11040] Support Webpack 5 #2116

Merged
merged 34 commits into from
Apr 25, 2024
Merged

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Apr 8, 2024

Goal

Export separate clients from /main and /renderer to allow smaller bundles and support webpack 5 without providing polyfills

Outstanding:

  • Re-instate failing windows tests

Design

Create a specific main and renderer process client, rather than detecting the process and creating one or the other.

Changeset

Update test fixture to use latest version of electron-forge and test up to electron v30
Update test assertions to match bundle changes from latest version of electron-forge

Testing

Skipped 2 failing tests which require further investigation

Copy link

github-actions bot commented Apr 8, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.80 kB 13.43 kB
After 43.80 kB 13.43 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 6f0bce1

@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch 3 times, most recently from 92cfc63 to aa9fb76 Compare April 10, 2024 16:45
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from 382c526 to ee6cf63 Compare April 18, 2024 15:05
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from ee6cf63 to 6489d1b Compare April 18, 2024 15:07
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from 819de70 to fb8da60 Compare April 19, 2024 13:09
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch 2 times, most recently from a68dffa to c0a3018 Compare April 22, 2024 10:49
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from c0a3018 to 0608171 Compare April 22, 2024 11:02
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from c1f6b8e to be604e7 Compare April 24, 2024 12:22
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from 5080725 to 2c9a998 Compare April 24, 2024 12:56
@gingerbenw gingerbenw changed the title [PLAT-11040] Export separate main and renderer clients [PLAT-11040] Support Webpack 5 Apr 24, 2024
@gingerbenw gingerbenw marked this pull request as ready for review April 24, 2024 13:12
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from 981cefc to b81e764 Compare April 24, 2024 13:20
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from 4594bf0 to a2b1bbe Compare April 24, 2024 13:32
@gingerbenw gingerbenw force-pushed the PLAT-11040/render-main-bundles branch from 4149309 to ebdea06 Compare April 24, 2024 13:42
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Exciting stuff!

@gingerbenw gingerbenw merged commit 900b9c0 into next Apr 25, 2024
58 of 60 checks passed
@gingerbenw gingerbenw deleted the PLAT-11040/render-main-bundles branch April 25, 2024 13:04
@gingerbenw gingerbenw mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants