-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAT-11040] Support Webpack 5 #2116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
3 times, most recently
from
April 10, 2024 16:45
92cfc63
to
aa9fb76
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 18, 2024 15:05
382c526
to
ee6cf63
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 18, 2024 15:07
ee6cf63
to
6489d1b
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 19, 2024 13:09
819de70
to
fb8da60
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
2 times, most recently
from
April 22, 2024 10:49
a68dffa
to
c0a3018
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 22, 2024 11:02
c0a3018
to
0608171
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 24, 2024 12:22
c1f6b8e
to
be604e7
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 24, 2024 12:56
5080725
to
2c9a998
Compare
gingerbenw
changed the title
[PLAT-11040] Export separate main and renderer clients
[PLAT-11040] Support Webpack 5
Apr 24, 2024
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 24, 2024 13:20
981cefc
to
b81e764
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 24, 2024 13:32
4594bf0
to
a2b1bbe
Compare
gingerbenw
force-pushed
the
PLAT-11040/render-main-bundles
branch
from
April 24, 2024 13:42
4149309
to
ebdea06
Compare
lemnik
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Exciting stuff!
yousif-bugsnag
approved these changes
Apr 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Export separate clients from
/main
and/renderer
to allow smaller bundles and support webpack 5 without providing polyfillsOutstanding:
Design
Create a specific main and renderer process client, rather than detecting the process and creating one or the other.
Changeset
Update test fixture to use latest version of electron-forge and test up to electron v30
Update test assertions to match bundle changes from latest version of electron-forge
Testing
Skipped 2 failing tests which require further investigation