Discard duplicate JS exceptions in iOS New Architecture

[yousif-bugsnag]

Goal

In the Old Architecture React Native raises an Objective-C RCTFatalException when an unhandled JS exception occurs. These are discarded in the native notifier because BugSnag's JS layer also catches these JS exceptions.

However in 0.73+, with New Architecture enabled, these exceptions are caught and rethrown as a cpp exception, so the discard pattern no longer applies and a duplicate native event is reported.

This PR adds an additional onSendError block (when the New Architecture is enabled) to also discard these new exception types

Design

Because this new exception type facebook::jsi::JSError is also thrown for any exceptions that occur in Turbo Module methods, we're not able to discard unhandled JS exceptions using a discardClasses pattern.

Instead an onSendError callback is used to discard based on the error message. For unhandled JS exceptions the error message is always prepended with Exception in HostFunction: Unhandled JS Exception

Changeset

Added a new onSendError block to the native config in BugsnagReactNativePlugin.m if the New Architecture is enabled.

The iOS New Architecture tests for 0.73 have been reinstated - as part of this all scenarios that throw native exceptions have been split into separate tests for old arch and new arch to account for the new exception handling behaviour in iOS Turbo Modules

Testing

Covered by a full CI run

[github-actions]

@bugsnag/browser bundle size diff

	Minified	Minfied + Gzipped
Before	43.80 kB	13.43 kB
After	43.80 kB	13.43 kB
±	No change	No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 529ed20

[gingerbenw]

Looks good to me - can I also say the PR description is great, loads of detail! 👍🏻