Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stacktrace js modules #354

Merged
merged 5 commits into from
Jun 4, 2018
Merged

Conversation

bengourley
Copy link
Contributor

@bengourley bengourley commented Jun 1, 2018

Goal

Fix a bug parsing stack traces with "@" in the URL path and switch to the main stack-generator now that our long-term dangling PR is merged/published

Changeset

Added

  • failing test for stacktrace parsing issue

Changed

  • package.json/package-lock.json were updated by the npm cli when it installed the updated modules

Tests

  • Verified that the test failed before the deps were upgraded and passed afterwards

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

URL paths with "@" in them incorrectly parse in Firefox/Safari due to a bug in the
error-stack-parser module
error-stack-parser contains a bugfix for the test in the previous commit
stack-generator published
a long-term dangling PR which we were depending on in a fork, so this just switches back to the main
package
kattrali
kattrali previously approved these changes Jun 1, 2018
@bengourley bengourley merged commit dd5ce9a into master Jun 4, 2018
@bengourley bengourley deleted the bengourley/stacktrace-js-bump branch June 4, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants