Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): Support "endpoint" option for builds/source maps #542

Merged
merged 1 commit into from
May 23, 2019

Conversation

bengourley
Copy link
Contributor

This change adds support for configuring endpoints on the source map upload and build reporter within the Expo post-publish hook.

Previously On-premise users would not have been able to configure the post-publish hook to speak to their endpoints.

Configuration in app.json should be set as follows:

    "hooks": {
      "postPublish": [
        {
          "file": "@bugsnag/expo/hooks/post-publish.js",
          "config": {
            "sourceMapUploader": { "endpoint": "https://upload-server.onprem.com" },
            "buildReporter": { "endpoint": "https://build-reporter.onprem.com" }
          }
        }
      ]
    }

A docs PR will be made once this change is approved.

Tested against a local bugsnag instance.

@tomlongridge tomlongridge requested a review from sazap10 May 23, 2019 09:32
Copy link

@sazap10 sazap10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bengourley bengourley merged commit 7f1d656 into next May 23, 2019
@bengourley bengourley deleted the expo-on-prem-config branch May 23, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants