Fix connecting from behind a proxy with agent
#546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this option was exposed, but it didn't actually get used by anything.
|
Hey @wadetandy this is now shipped in v6.3.1. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to get bugsnag working behind our corporate firewall, I had
problems using the instructions about hooking in
https-proxy-agent, andthe agent configuration was not obeyed. When I went digging into the code
I realized the config option was never actually passed to the
https.request()call within the
deliver()function. This fixes that.Also it seems that this integration test
is not testing what its supposed to, but I'm not familiar enough with the Maze Runner
tests to be able to fix it myself (plus it seems from CONTRIBUTING.md that I can't run it
anyway).