V7: rename "report" to "event" #646
Conversation
bengourley
force-pushed
the
v7-rename-report-event
branch
from
5ee7623
to
d65f902
Compare
This prerelease dependency which is not in git tree meant these packages got installed from npm rather than symlinking locally – meaning the tests broke after the refactor.
bengourley
force-pushed
the
v7-rename-report-event
branch
from
d65f902
to
cba9d08
Compare
| sendReport: (report) => { | ||
| const evt = report.events[0] | ||
| sendEvent: (event) => { | ||
| const evt = event.events[0] |
There was a problem hiding this comment.
Can an event can contain sub-events or is this a kind of naming conflict?
There was a problem hiding this comment.
it's a poor choice of name – the argument should be called payload
| @@ -20,7 +20,7 @@ | |||
| "author": "Bugsnag", | |||
| "license": "MIT", | |||
| "devDependencies": { | |||
| "@bugsnag/core": "^7.0.0-pre-alpha-ben.6", | |||
| "@bugsnag/core": "^6.4.1", | |||
There was a problem hiding this comment.
Should this be part of this PR?
There was a problem hiding this comment.
Yeah the explanation is in this commit: c342609
It was needed to ensure the tests pass.
| @@ -20,7 +20,7 @@ | |||
| "author": "Bugsnag", | |||
| "license": "MIT", | |||
| "devDependencies": { | |||
| "@bugsnag/core": "^7.0.0-pre-alpha-ben.6", | |||
| "@bugsnag/core": "^6.4.1", | |||
There was a problem hiding this comment.
Should this be part of this PR?
packages/plugin-react-native-unhandled-rejection/test/rejection-handler.test.js
Outdated
Show resolved
Hide resolved
I left these in on purpose – we still "report errors" (the spec even has a section called "reporting errors") – it's just the construct in code which has changed. I'll address all your other comments though, they're useful 👍 |
- disambiguate event/payload sendEvent argument in tests - fix grammar - fix overzealous find and replaces
bengourley
force-pushed
the
v7-rename-report-event
branch
from
8a04f05
to
9b1873f
Compare
The construct represented by the "report" class in this codebase is now called "event" in the spec. This also now matches up with the concept of an "event" in our dashboard and other areas of the product.
There are changes to be made to its interface, but these will be included in subsequent PRs.
No functionality should have been changed here, literally just the naming.