Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7: Notify signature #655

Merged
merged 6 commits into from
Nov 29, 2019
Merged

V7: Notify signature #655

merged 6 commits into from
Nov 29, 2019

Conversation

bengourley
Copy link
Contributor

@bengourley bengourley commented Nov 27, 2019 •
edited
Loading

Updates the signature of notify() to be notify(err, onError?, cb?). The opts parameter is gone – there is now a canonical way to provide properties to an event and that is to use an onError callback

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Nov 27, 2019 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.79 kB 12.11 kB
After 39.43 kB 12.00 kB
± -356 bytes -106 bytes

Generated by 🚫 dangerJS against 0d534ab

@bengourley bengourley marked this pull request as ready for review November 28, 2019 10:05
@bengourley bengourley merged commit ede9a64 into v7 Nov 29, 2019
@bengourley bengourley deleted the v7-notify-signature branch November 29, 2019 13:55
@bengourley bengourley mentioned this pull request Dec 2, 2019
Merged
@bengourley bengourley mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bengourley @bugsnagbot @djskinner