Expo v36 support #670
Merged
Expo v36 support #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djskinner
approved these changes
Dec 10, 2019
…dividual packages
tomlongridge
approved these changes
Dec 16, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Expo 36, the
react-nativemodule no longer hasNetInfoinstalled by default. This means@bugsnag/expoin its current state does not work with SDK 36 (#668).This PR adds the
@react-native-community/netinfopackage as a dependency to@bugsnag/expo, and updates its usage (the api of the module has changed since it moved to the community org).In the same way we supported SDK 34 and had to drop support for older versions (#610), this PR also updates
bugsnag-expo-clito install the relevant version of Bugsnag for the Expo SDK version detected.