V7: Rename trackError -> _track and remove from public types #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
force-pushed
the
v7-track-event
branch
from
2157fd1
to
b76b550
Compare
bengourley
force-pushed
the
v7-track-event
branch
from
7aaa707
to
195f3f6
Compare
|
it's now a tiny bit smaller which is to be expected |
djskinner
approved these changes
Dec 18, 2019
bengourley
force-pushed
the
v7-track-event
branch
from
195f3f6
to
2025a04
Compare
bengourley
force-pushed
the
v7-track-event
branch
from
2025a04
to
7b29890
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sessions are now part of the public interface via
onSessioncallbacks, so the publictrackError()function has been suitably renamed (it takes events not errors) and made private.