src/bugsnag: fix Opera Mobile test failures #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but for legacy support, I'd recommend doing something like this... var scripts = document.scripts || document.getElementsByTagName("script");
I have a large client still on FF3.0, so I'd love to continue to support them :) |
The old approach was giving failures on Opera Mobile (and probably some other minor browsers). The problem is that `document.currentScript` is unsupported by Opera Mobile, so it was always undefined (hence, `lastScript`, too). We use `document.scripts` instead. It is supported by all browsers: https://developer.mozilla.org/en-US/docs/Web/API/document.scripts
kyrylo
force-pushed
the
opera-mobile-tests-fix
branch
from
4eefe8f
to
088b585
Compare
|
Thank you. Fixed :) |
ConradIrwin
added a commit
that referenced
this pull request
Aug 23, 2014
src/bugsnag: fix Opera Mobile test failures
kattrali
pushed a commit
that referenced
this pull request
Apr 22, 2021
Allow Act to run the tests with Ubuntu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67 (Some tests fail on Opera Mobile)
The old approach was giving failures on Opera Mobile (and probably
some other minor browsers). The problem is that
document.currentScriptis unsupported by Opera Mobile, so it wasalways undefined (hence,
lastScript, too).We use
document.scriptsinstead. It is supported by all browsers:https://developer.mozilla.org/en-US/docs/Web/API/document.scripts