Implemented loop based on hidden candidates

[elmosgot]

Now all candidates are found to be wrapped. The only thing that is affected here is the performance from avg of 5ms to an avg of 30ms, about 6 times slower.

[jmshal]

Probably should do with a check to see if Object.getOwnPropertyNames is defined (< IE9).

[jmshal]

I really like this, and based on the comment (above the previous code), it would seem that the issue of Object.getOwnPropertyNames not being available in IE8 and below, isn't a problem. Am I wrong by thinking that (as mentioned) the only browsers that require that last part are 'modern' Opera, Safari, Chrome, FF and IE11?

[elmosgot]

Yeah you're right that we need to check first if getOwnPropertyNames exists to not break in old browser versions.

The part of getting nice stack traces is anyway only working on newer browsers. Otherwise we use the fallback to the previous method for the browser that have not implemented getOwnPropertyNames and do have prototype inheritance support.

But as for I read here the both features are implemented in the same releases:
http://kangax.github.io/compat-table/es5/#

[elmosgot]

From firebug source I found the following check:

var isObjectPrototype = function(obj)
{
// Check if an object is "Object.prototype". This isn't as simple
// as 'obj === context.window.wrappedJSObject.Object.prototype' due
// to cross-window properties, nor just '!Object.getPrototypeOf(obj)'
// because of Object.create.
return !Object.getPrototypeOf(obj) && "hasOwnProperty" in obj;
};

We can use that to determine the availability if the object contains getPrototypeOf

[ConradIrwin]

Hey @elmosgot! Thanks for this, I love the code simplification.

Unfortunately this approach seems to reliably lock up Safari (Tested with Desktop 7.0.6, and iOS 6). The test suite just gets to test 40 and then stops on 100% CPU forever.

Out of interest how did you measure the slowdown? Using console.time() and console.timeEnd() I measured before -> after as 1ms to 2ms (in Chrome/Firefox).

I think it would be safer for now to add things that we find are missing to the list, have you run across anything in the real world?