Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expo SDK 37 support #781

Merged
merged 6 commits into from
Apr 2, 2020
Merged

Expo SDK 37 support #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43264b5
feat(expo): Support Expo SDK 37
bengourley Mar 23, 2020
121cdf4
feat(expo-cli): Ensure fresh installs on old Expo SDKs get a compatib…
bengourley Mar 23, 2020
29a0694
test(expo): Update tests to run against SDK37
bengourley Apr 1, 2020
b5a3ebe
ci(expo): Update to latest turtle-cli
bengourley Apr 1, 2020
f584a75
test(expo): For some reason the expo upgrade command removed this
bengourley Apr 1, 2020
958990c
ci(expo): Trying to get Expo CI working
bengourley Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dockerfiles/Dockerfile.expo-android-builder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list

RUN apt-get update
RUN apt-get install -y nodejs make g++ yarn rsync
RUN apt-get install -y nodejs make g++ yarn rsync jq

WORKDIR /app/test/expo/features/fixtures/test-app

RUN mkdir -p /app/test/expo/features/fixures/build

RUN yarn global add gulp-cli node-gyp
RUN yarn add bunyan rsync turtle-cli@0.13.1
RUN yarn add bunyan rsync turtle-cli@0.14

RUN node_modules/.bin/turtle setup:android

Expand Down
6 changes: 3 additions & 3 deletions packages/delivery-expo/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/delivery-expo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"license": "MIT",
"dependencies": {
"@bugsnag/core": "^6.5.0",
"@react-native-community/netinfo": "4.6.0",
"@react-native-community/netinfo": "5.5.0",
"expo-file-system": "^6.0.2"
},
"devDependencies": {
Expand Down
4 changes: 4 additions & 0 deletions packages/expo-cli/commands/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,17 @@ const selectVersion = async (dir) => {
// help select compatible versions of @bugsnag/expo for older expo releases
const isPre33 = (expoVersion && !semver.gte(semver.minVersion(expoVersion), '33.0.0'))
const isPre36 = (expoVersion && !semver.gte(semver.minVersion(expoVersion), '36.0.0'))
const isPre37 = (expoVersion && !semver.gte(semver.minVersion(expoVersion), '37.0.0'))

if (isPre33) {
message = 'It looks like you’re using a version of Expo SDK <33. The last version of Bugsnag that supported your version of Expo is v6.3.0'
defaultVersion = '6.3.0'
} else if (isPre36) {
message = 'It looks like you’re using a version of Expo SDK <36. The last version of Bugsnag that supported your version of Expo is v6.4.1'
defaultVersion = '6.4.1'
} else if (isPre37) {
message = 'It looks like you’re using a version of Expo SDK <37. The last version of Bugsnag that supported your version of Expo is v6.5.1'
defaultVersion = '6.5.1'
}

const { version } = await prompts({
Expand Down
6 changes: 3 additions & 3 deletions packages/plugin-react-native-connectivity-breadcrumbs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/plugin-react-native-connectivity-breadcrumbs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"author": "Bugsnag",
"license": "MIT",
"dependencies": {
"@react-native-community/netinfo": "4.6.0"
"@react-native-community/netinfo": "5.5.0"
},
"devDependencies": {
"@bugsnag/core": "^6.5.0",
Expand Down
2 changes: 1 addition & 1 deletion test/expo/features/fixtures/test-app/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "Test Fixture",
"slug": "test-fixture",
"privacy": "unlisted",
"sdkVersion": "36.0.0",
"sdkVersion": "37.0.0",
"platforms": [
"ios",
"android"
Expand Down
Loading