Add support for almond.js [Fixes #81] #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump |
kattrali
pushed a commit
that referenced
this pull request
Apr 22, 2021
Validate payloads before queuing/returning them from queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would seem that because almond.js does not make any requests to external files (due to it being a library for concatenated AMD modules), we can check whether the AMD implementation has the
require.loadfunction - which is used to load external files into the DOM.So, ideally, this should fix issue #81. I've set the module name to
Bugsnagto match the name of the global variable Bugsnag uses when no module loading library is used.Feedback?