Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Ensure start method is named correctly #847

Merged
merged 2 commits into from
May 12, 2020
Merged

fix(types): Ensure start method is named correctly #847

merged 2 commits into from
May 12, 2020

Conversation

bengourley
Copy link
Contributor

Fixes #844.

The start method was named init for a while during the V7 implementation. This rename was missed.

@bengourley bengourley requested a review from djskinner May 12, 2020 09:00
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented May 12, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.28 kB 12.12 kB
After 39.28 kB 12.12 kB
± No change No change

Generated by 🚫 dangerJS against 59cc653

@bengourley bengourley merged commit 60007e1 into next May 12, 2020
@bengourley bengourley deleted the bengourley/fix-types-init-start branch May 12, 2020 10:50
@bengourley bengourley mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v7 collectUserIP missing?
3 participants
@bengourley @bugsnagbot @djskinner