test: convert tests to jest #929
Conversation
| @@ -1,38 +1,37 @@ | |||
| const { describe, it, expect } = global | |||
| /* eslint-disable @typescript-eslint/no-non-null-assertion */ | |||
There was a problem hiding this comment.
I wonder if it's worth disabling this rule across all test files as its usage is often legitimate and useful.
Often there are cases where a previous assertion asserts the existence of something. Unfortunately the typings of expect aren't sufficient to avail the TS compiler of such knowledge (perhaps it is possible to do with better typings that use assertion signatures - I'm not sure). Even without the benefit of previous assertions, it seems legitimate to me to make assumptions about the existence of things because the test would just fail otherwise.
FWIW we agreed that it would be OK disable this rule in the dashboard-js project though we haven't got round to doing it yet. That might be because in that project we are more relaxed about overriding rules on a per-line or entire file basis where judged appropriate.
On a related note I've seen a few places in the tests where the optional chaining ?. operator would be useful. Though currently jest doesn't like it when used. I think we might need to update our TypeScript/jest/babel dependencies if we want to make use of that one.
There was a problem hiding this comment.
I think it's a reasonable thing to assert. Since the implementation is JS, the type system doesn't guarantee that such things are genuinely non-null.
Maybe updating the test dev dependencies should come in via another PR. The ?. and also ! are nice operators for terse TS so it would be good to have access to them.
Convert the following packages' test files to TypeScript and jest:
plugin-node-in-projectplugin-node-deviceplugin-node-surrounding-codeplugin-node-uncaught-exception