perf: Expand reflected calls into Client methods #510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improve performance and shrink callstacks by removing the reflection calls from
Client
toConfiguration
. Also beef up test coverage for config options!Related to #476
Changeset
Removed the
__call
method fromClient
, replacing it with the instance methods fromConfiguration
.Tests
Added new unit tests for the return values and behaviors of
Client
to ensure that:The tests pass before and after the change.