-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump httpclient allowed payload limit #538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kattrali I wonder if the payload limit was 512kb in 2015, which would explain why the code is like this? |
kattrali
suggested changes
Aug 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @qwertyuu! I took a quick look and it seems fine aside from a few small issues.
@kattrali Comment added! |
kattrali
approved these changes
Aug 23, 2019
Thanks for the quick edits! ⚡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Bring the upload limit closer to the actual Bugsnag's error reporting limit, see: https://github.com/bugsnag/bugsnag-dotnet/blob/96360fb0f8d31f5fd6a8f3f17184bd626421820e/src/Bugsnag/Payload/Report.cs#L16
from
bugsnag-dotnet
. Also here in the documentation: https://docs.bugsnag.com/platforms/dotnet/asp-net/configuration-options/#maximum-breadcrumbsChangeset
Changed
Changed
MAX_SIZE
const inHttpClient
to 1024*1024, or 1048576.Tests
Used the new constant to ensure that "massive payloads" are properly tested if the value ever changes.
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: