Add HTTP basic auth headers to default filters #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically only 'authorization' is used as a header, but PHP will parse the username & password (or digest) — these aren't counted as headers by PHP, but Symfony treats them as headers. Since a lot of other projects use Symfony's HTTP foundation (e.g. Laravel), it makes sense to add them as default filters too
imjoehaines
force-pushed
the
http-basic-auth-filters
branch
from
856f15c
to
ab959da
Compare
kattrali
approved these changes
Sep 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds the "authorization" header and related PHP auth headers to the default list of filters. This matches the behaviour of our other server notifiers (e.g. Ruby & Python)
Design
Technically only "authorization" is used as a header, but PHP will parse the username & password (or digest) too when using HTTP basic/digest auth
These aren't counted as headers by PHP (or by bugsnag-php), but Symfony's HTTP Foundation library treats them as headers. Since a lot of other projects also use Symfony's HTTP Foundation (e.g. Laravel), it makes sense to add them as default filters too
Testing
Built on tests added in #596 and manually tested with vanilla PHP, Laravel and Symfony