Add a default timeout & connect_timeout to Guzzle #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
By default Guzzle has no timeout, meaning it waits indefinitely for requests to finish. This PR applys a very conservative default timeout of 15 seconds to avoid blocking scripts forever*
This is only applied when Bugsnag constructs the Guzzle instance used; if one is provided in the constructor, no timeout will be added (though it can, of course, provide its own timeout value)
Design
To avoid yet more Guzzle version checks, I've consolidated them into a new
GuzzleCompatclassTesting
Some basic unit tests check that a timeout is applied by
makeGuzzle. Testing the timeout itself is a bit out of scope