Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libsec update #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Libsec update #149

wants to merge 1 commit into from

Conversation

jimmysong
Copy link
Collaborator

Updated libsec function as one of them is now deprecated.
Also changed the README instructions as they were out of date.

… ffi stuff to accomodate. Also changed the README instructions as they were out of date.
@jimmysong jimmysong requested a review from mflaxman June 8, 2023 04:42
@@ -75,15 +75,6 @@ You can speed this library up ~100x by using C-bindings to [bitcoin core's `libs

### `libsecp256k1` Dependency Installation


#### Easy (MacOS only)
Use [brew](https://brew.sh/) to install `libsecp256k1`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why get rid of this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the brew install doesn't have these options enabled --enable-module-extrakeys --enable-module-schnorrsig --enable-experimental so it fails.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That used to be true, but I fixed that upstream in 2021!
cuber/homebrew-libsecp256k1@50639e1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, then the upstream libsecp256k1 needs to upgrade to the latest version because that one still uses the deprecated function. How do I do that?

Copy link
Collaborator

@mflaxman mflaxman Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you just change the version number and hash digest here:
https://github.com/cuber/homebrew-libsecp256k1/blob/master/libsecp256k1.rb

(You can do it on your own branch/repo and use $ brew tap for testing)

@mflaxman mflaxman mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants