Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run doctests after cargo nextest #3183

Merged
merged 1 commit into from
Aug 9, 2022
Merged

ci: run doctests after cargo nextest #3183

merged 1 commit into from
Aug 9, 2022

Conversation

neil2468
Copy link
Contributor

@neil2468 neil2468 commented Aug 9, 2022

Current Behavior

Issue #3033 identified that Rust doctests are not being run by the GitHub CI. This is because...

Proposed Changes

  • Modify CI so cargo test --doc is run after cargo nextest.
  • In gradle script, rename environmentCI() to environmentVars() so it makes more sense.

Fixes #3033.

Checks

@neil2468 neil2468 requested a review from a team as a code owner August 9, 2022 15:03
@mrinalwadhwa
Copy link
Member

Thank you for another awesome contribution! That looks great 🥳

@mergify mergify bot merged commit 53168bf into build-trust:develop Aug 9, 2022
@neil2468 neil2468 deleted the neil2468/with_nextest_run_doctests_separately branch November 1, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI doesn't run rust doc tests
2 participants