ci_runner: cleanup previously setup repo #6869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up well known files that could cause subsequent git operations to fail.
sluongng
force-pushed
the
sluongng/cleanup-git-files
branch
from
03c8e17
to
3da4637
Compare
bduffany
requested changes
Jun 18, 2024
Comment on lines
+1697
to
+1701
| "index.lock", | ||
| "shallow.lock", | ||
| "HEAD.lock", | ||
| "hooks/post-checkout", | ||
| "config.lock", |
There was a problem hiding this comment.
how certain are we that it's safe to delete these files? could there be some background process running that's using these? And if we delete these lockfiles could we wind up clobbering the git repo state? (because the bg processes will think they have the lock but they really don't)
There was a problem hiding this comment.
I'd prefer to wait for us having an example of this being an issue before checking this in. Maggie investigated the hang and didn't see any of these files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up well known files that could cause subsequent git operations to
fail.