Add prefix to API keys to make them easy to identify by scanners. #7115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My plan is to configure the following prefixes: Prod: bbak_ Dev: bbakd_ All other: bbaki_ Rollout strategy: - First release will accept prefixed API keys but will not yet generate keys with a prefix - Second release will start generating new keys with a prefix. Non-prefixed API keys will continue to be accepted. buildbuddy-io/buildbuddy-internal#3644
|
Was talking to @siggisim about this a little -- for prefixes, could we use:
|
how about |
bduffany
approved these changes
Jul 29, 2024
|
@tylerwilliams @siggisim ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My plan is to configure the following prefixes:
Prod: bb_key_
Non-prod: bb_dev_
All other: bb_ent_
Rollout strategy:
https://github.com/buildbuddy-io/buildbuddy-internal/issues/3644
Related issues: N/A