Schema changes for serving Executions page using ClickHouse #7414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luluz66
reviewed
Sep 10, 2024
luluz66
approved these changes
Sep 10, 2024
tylerwilliams
approved these changes
Sep 11, 2024
|
Updated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing pieces of data needed to render the Executions page using ClickHouse. Updates both the ClickHouse table schema as well as its proto representation (
StoredExecution) which gets buffered in Redis while invocations are in progress, and later flushed at the end of the invocation.Related issues: https://github.com/orgs/buildbuddy-io/projects/7/views/7?pane=issue&itemId=62162316