Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Proxy: add a few graphs to the Grafana dashboard #7515

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Cache Proxy: add a few graphs to the Grafana dashboard #7515

merged 4 commits into from
Sep 23, 2024

Conversation

iain-macdonald
Copy link
Contributor

This PR adds two sections to the Grafana dashboard:

  • "gRPC (cache proxy)" which contains all of the same graphs as "gRPC (buildbuddy-app)" but pointed at the cache proxy instead and
  • "Cache proxy" which contains graphs tracking the hit/miss/partial performance of the ByteStream Proxy Server and CAS Proxy Server. CAS Proxy requests are tracked both by request (on the left axis) and by digest (on the right axis).

Related issues: N/A

bduffany
bduffany reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new grpc panel could you configure the existing one to repeat for each job like we do for the golang one?

tools/metrics/grafana/dashboards/buildbuddy.json Outdated
Comment on lines 16747 to 16316
"title": "BuildBuddy Metricssss",
"uid": "d246b6c6-7247-4b7e-849e-07f405d4ccb6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a 🐍 write this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busssssted

@iain-macdonald
Copy link
Contributor Author

Instead of adding a new grpc panel could you configure the existing one to repeat for each job like we do for the golang one?

sounds good, done!

bduffany
bduffany reviewed Sep 23, 2024
View reviewed changes
tools/metrics/grafana/dashboards/buildbuddy.json Outdated
@@ -16140,6 +16313,6 @@
},
"timezone": "",
"title": "BuildBuddy Metrics",
"uid": "1rsE5yoGz",
"uid": "d246b6c6-7247-4b7e-849e-07f405d4ccb6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why it's trying to update the uid? this uid appears in the URL so this might break some things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure, maybe because I saved it under a different name due to that other bug I mentioned to you. In any case, reverted.

@iain-macdonald iain-macdonald merged commit 3a076e8 into master Sep 23, 2024
15 checks passed
@iain-macdonald iain-macdonald deleted the proxy_dashboard branch September 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bduffany bduffany bduffany approved these changes

@vadimberezniker vadimberezniker Awaiting requested review from vadimberezniker

@tylerwilliams tylerwilliams Awaiting requested review from tylerwilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iain-macdonald @tylerwilliams @bduffany