Upgrade prettier since the old one is incompatible with newer libc versions #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhollen
approved these changes
Oct 16, 2024
bduffany
added a commit
that referenced
this pull request
Nov 13, 2024
The version upgrade in #7741 is causing unexpected prettier diffs whenever we change certain files. This is because prettier 3.x introduced new formatting rules, but our prettier script only checks/formats changed files. So, in the upgrade PR, Checkstyle didn't complain about the formatting now being incorrect after the upgrade, and the latent formatting errors are being surfaced in PRs only as the files are edited. This PR reverts prettier back to 2.1.1 and updates Checkstyle to catch this error in CI - if the prettier version in yarn.lock changes, then all files are checked/formatted, not just changed files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this on ubuntu 2204 when trying get buildbuddy building on arm.
jsxBracketSameLineis deprecated, now justbracketSameLine: https://prettier.io/blog/2021/09/09/2.4.0.html#:~:text=This%20release%20renames%20the%20jsxBracketSameLine,such%20as%20class%20static%20blocks--loglevelwas renamed to--log-levelRelated issues: N/A