Replicate local absolute path on remote machine #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sync.rs
Outdated
| fn project_dir_on_remote_machine(local_project_dir_name: &str) -> String { | ||
| format!("~/mainframer/{}", local_project_dir_name) | ||
| pub fn project_dir_on_remote_machine(local_dir_absolute_path: &Path) -> String { | ||
| format!("~/mainframer/{}", local_dir_absolute_path.to_string_lossy()) |
There was a problem hiding this comment.
Could it be here "~/mainframer//home/user/project" as a result?
There was a problem hiding this comment.
Snap, good catch 👍
Most of the time it's harmless to do so (you can check in your terminal), but I definitely did not intend that
There was a problem hiding this comment.
foxed, thanks again 😽
arturdryomov
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214.
As discussed in #214, we now replicate absolute path from local machine in
~/mainframer/…on remote machine.This allows user to have multiple projects with same leaf node in the path without clashing, ie:
/home/artem_zin/myproject→/home/remote_user/mainframer/home/artem_zin/myproject/home/artem_zin/projects/myproject→/home/remote_user/mainframer/home/artem_zin/projects/myprojectWe can also add local machine hostname, but I don't think it's a good idea.
Integration tests were updated to expect files in new path. Also tested myself.