BCF-API #290 add object translucency support in viewpoints #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgDangl
force-pushed
the
bcf-api-290-support-translucent-color
branch
from
77bfd48
to
8936925
Compare
GeorgDangl
reviewed
Jul 3, 2023
Comment on lines
+146
to
+150
| <xs:element name="Exceptions" minOccurs="0"> | ||
| <!-- Inverses DefaultTranslucency and TranslucencySetupHints --> | ||
| <xs:complexType> | ||
| <xs:sequence> | ||
| <xs:element name="Component" type="Component" minOccurs="0" maxOccurs="unbounded"/> |
There was a problem hiding this comment.
From @pjanck: Use minOccurs="1" in the inner list, if the Exception object is present, then it should have at least one exception.
There was a problem hiding this comment.
I propose that this should be corrected across visinfo.xsd in a single pull request rather than fixing just for translucency.
Otherwise, we would risk leaving visinfo.xsd inconsistent.
GeorgDangl
reviewed
Jul 3, 2023
Comment on lines
+146
to
+150
| <xs:element name="Exceptions" minOccurs="0"> | ||
| <!-- Inverses DefaultTranslucency and TranslucencySetupHints --> | ||
| <xs:complexType> | ||
| <xs:sequence> | ||
| <xs:element name="Component" type="Component" minOccurs="0" maxOccurs="unbounded"/> |
There was a problem hiding this comment.
Suggested change
| <xs:element name="Exceptions" minOccurs="0"> | |
| <!-- Inverses DefaultTranslucency and TranslucencySetupHints --> | |
| <xs:complexType> | |
| <xs:sequence> | |
| <xs:element name="Component" type="Component" minOccurs="0" maxOccurs="unbounded"/> | |
| <xs:element name="Exceptions" minOccurs="0"> | |
| <!-- Inverses DefaultTranslucency and TranslucencySetupHints --> | |
| <xs:complexType> | |
| <xs:sequence> | |
| <xs:element name="Component" type="Component" minOccurs="1" maxOccurs="unbounded"/> |
Remove comment when squashed.
pasi-paasiala
approved these changes
Nov 28, 2023
GeorgDangl
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in buildingSMART/BCF-API#290