Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a command to allow removal of existing annotations #1364

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Add a command to allow removal of existing annotations #1364

merged 4 commits into from
Feb 26, 2021

Conversation

ticky
Copy link
Contributor

@ticky ticky commented Jan 22, 2021

No description provided.

@ticky
Copy link
Contributor Author

ticky commented Jan 22, 2021

This… somehow breaks the BSD build? 😔

@ticky ticky force-pushed the allow-removal-of-annotations branch from 50c41a3 to 5a1794f Compare January 25, 2021 20:10
@sj26
Copy link
Member

sj26 commented Feb 1, 2021

It feels odd to me to add this to the existing command. Could we perhaps add a new command?

There's good precedence for buildlite-agent noun verb. Perhaps buildkite-agent annotation remove --context=blah would be a good choice?

Base automatically changed from master to main February 1, 2021 05:25
@ticky ticky force-pushed the allow-removal-of-annotations branch from 5a1794f to e7034f6 Compare February 5, 2021 01:58
@ticky ticky marked this pull request as ready for review February 17, 2021 23:50
@ticky ticky force-pushed the allow-removal-of-annotations branch from 3b1d0a1 to 3a70083 Compare February 18, 2021 00:01
@ticky ticky requested a review from a team February 23, 2021 22:50
sj26
sj26 previously approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@sj26 sj26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I gave this a go against the corresponding agent API changes and it works a treat. 👍

@ticky ticky changed the title Add a flag to annotate to allow removal of existing annotations Add a command to allow removal of existing annotations Feb 26, 2021
@ticky @sj26
Fix tense in usage of job flag
03fda1b 
Co-authored-by: Samuel Cochran <[email protected]>
@ticky
Copy link
Contributor Author

ticky commented Feb 26, 2021

Using my privileges to merge this because the code changes since the review were not meaningful.

@ticky ticky merged commit b9bc5ec into main Feb 26, 2021
@ticky ticky deleted the allow-removal-of-annotations branch February 26, 2021 18:15
ticky added a commit to buildkite/docs that referenced this pull request Mar 4, 2021
@ticky
Add documentation for the buildkite-agent annotation remove command.
5774a83 
Note that the referenced v3.28.0 agent version doesn't exist yet, so this shouldn't be merged until we've made a call on releasing that version.

Context: buildkite/agent#1364, buildkite/buildkite#5948.
@ticky ticky mentioned this pull request Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sj26 sj26 sj26 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ticky @sj26