Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow signal bootstrap sends to commands on cancel to be customized #1390

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Allow signal bootstrap sends to commands on cancel to be customized #1390

merged 2 commits into from
Mar 16, 2021

Commits on Mar 3, 2021

  1. Allow signal bootstrap sends to commands on cancel to be customized 

    Currently bootstrap sends a `SIGTERM` to commands when it, itself, is interrupted.

This adds `cancel-signal` which accepts signals in the form of SIGTERM, SIGHUP, etc.

This is the same config that `start` accepts, and is based on the PR that added that feature: #1041

Finally, `start` passes its `cancel-signal` to `bootstrap`, to prevent having to customize the `bootstrap-script`.
    @brentleyjones
    brentleyjones committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    e020fb9 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. JobRunner passes CancelSignal to bootstrap via env not argv

    @pda
    pda committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    086eabe View commit details
    Browse the repository at this point in the history