Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow uploading pipelines containing interpolated secrets by default #1593

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Mar 23, 2022

Further to #1589, pipeline secret redaction should become default in Agent v4.

This PR makes it so that default behaviour is to disallow pipeline uploads containing interpolations of potentially secret environment variables. We add flag to buildkite-agent pipeline upload to allow uploading pipelines with these secrets, but note in the CLI help and the log output that this behaviour is insecure.

We won't merge this until we release Agent v4

@moskyb moskyb added the breaking Changes to existing behaviour users might rely on label Mar 23, 2022
@yob
Copy link
Contributor

yob commented Mar 23, 2022

pipeline secret redaction should become default in Agent v4.

I don't know if this issue is complete, but there's an historical attempt to list the breaking changes we're saving for v4 over in #1391

@moskyb
Copy link
Contributor Author

moskyb commented Mar 23, 2022

@yob already in there :)

@moskyb moskyb added the v4 Breaking changes that will be included in Agent v4 label Mar 23, 2022
@moskyb moskyb changed the title Make pipeline secret redaction default behaviour Disallow uploading pipelines containing interpolated secrets by default Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Changes to existing behaviour users might rely on v4 Breaking changes that will be included in Agent v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants