Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retry on not found resource #1731

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leakingtapan
Copy link

We found Buildkite agent retry on 404 when downloading artifacts, but this is unnecessary. Since we have extended retry (up to 30 mins), the current behavior (retry on 404) largely slows down the progress to fail fast. So add the small patch to skip retry on 404 for artifact download.

@leakingtapan
Copy link
Author

@lox

@lox
Copy link
Contributor

lox commented Jul 29, 2022

I'm no longer Buildkite staff @leakingtapan! Just a contributor like yourself.

@leakingtapan
Copy link
Author

leakingtapan commented Jul 29, 2022

@lox ah, got it.

@leakingtapan
Copy link
Author

@moskyb could you take a look? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants