Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub release now that we're using OIDC #134

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Fix GitHub release now that we're using OIDC #134

merged 1 commit into from
Mar 17, 2023

Conversation

yob
Copy link
Contributor

@yob yob commented Mar 17, 2023

In #133 we updated the relase steps to use OIDC for assuming roles as needed. The release to s3 steps worked as planned, however the release to GitHub step needs some tweaks:

  1. fix the SSM parameter store path
  2. explictly pass the environment variable into the docker container

@yob
Fix GitHub release now that we're using OIDC
8ab672b 
In #133 we updated the relase steps to use OIDC for assuming roles as
needed. The release to s3 steps worked as planned, however the release
to GitHub step needs some tweaks:

1. fix the SSM parameter store path
2. explictly pass the environment variable into the docker container
yob
yob commented Mar 17, 2023
View reviewed changes
Copy link
Contributor Author

@yob yob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard to test without just trying it, so... YOLO

@yob yob merged commit a6c476f into master Mar 17, 2023
@yob yob deleted the tweak-release-steps branch March 17, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yob