Ensure statsd commands are flushed after each run #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For fixing the issue I need a library version that supports Flush() and the vendored one didn't.
Statsd client sometimes don't send its paiload just after the commands are sent via buffered client, this commit ensures that there's a Flush because if `buildkite-metrics` is used without interval the automatic flush of the client (100ms or 100 commands) may not happen. This commit calls client.Flush() to ensure all the commands created are sent to the statsd
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates StatsD client library and flushes statsd commands at the end of
Collectcall to fix #37 This is something that happened to us while using the statsd backend without the-intervalparameter.I've tested the resulting binary with and without
-intervalto check that don't change its behaviour.