add support for buildkite token from ssm #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @arromer, this looks good. Perhaps could we go for |
lox
reviewed
Mar 26, 2019
backend/ssm.go
Outdated
| "sync" | ||
| ) | ||
|
|
||
| var ssmClient *ssm.SSM |
There was a problem hiding this comment.
Think it's worth caching this client between lambda invocations?
lox
reviewed
Mar 26, 2019
backend/ssm.go
Outdated
|
|
||
| func GetSsmClient() *ssm.SSM { | ||
| once.Do(func() { | ||
| ssmClient = ssm.New(session.Must(session.NewSession())) |
There was a problem hiding this comment.
Perhaps move this into RetrieveFromParameterStore and use an if ssmClient != nil check vs sync.once.
arromer
added a commit
to arromer/buildkite-agent-metrics
that referenced
this pull request
Mar 28, 2019
|
Sorry for being slow to get this merged in, really appreciate your patience and the contribution! 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssm support extracted from #59