Scaler cleanups #188
Merged
Scaler cleanups #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearrange the loop so that scaler.Run happens first. This also lets us check for timeout while sleeping.
log.Printf includes newline Also we're now waiting for timeout or sleep
* Build container (Makefile) * Pipeline containers (pipeline.yaml) * go.mod * go get -u && go mod tidy
DrJosh9000
force-pushed
the
scaler-cleanups
branch
from
e897efd
to
362507e
Compare
DrJosh9000
force-pushed
the
scaler-cleanups
branch
from
4765921
to
5a27c3a
Compare
wolfeidau
requested changes
Jul 18, 2024
lambda/main.go
Outdated
Comment on lines
79
to
86
| agentsPerInstanceStr := os.Getenv("AGENTS_PER_INSTANCE") | ||
| if agentsPerInstanceStr == "" { | ||
| return "", errors.New("AGENTS_PER_INSTANCE is required") | ||
| } | ||
| agentsPerInstance, err := strconv.Atoi(agentsPerInstanceStr) | ||
| if err != nil { | ||
| return "", fmt.Errorf("AGENTS_PER_INSTANCE must be an integer: %w", err) | ||
| } |
There was a problem hiding this comment.
I would prefer a function for this
There was a problem hiding this comment.
I've refactored the environment variable loading back towards a few helper functions, which I feel also resolves the comments below. Since they all error out of the lambda handler, making it useless, I've leaned towards log.Fatalf.
wolfeidau
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a grab-bag of code cleanups.
The only significant change should be that
scaler.Runnow happens before checkingtimeout, so the lambda won't time out before it does anything useful (regardless ofLAMBDA_TIMEOUT).