Allow running scaler with a fixed size instance buffer #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help fleets where instance startup time is slow, by allowing them to configure enough free instances to handle a certain amount of load while new instances spin up.
|
Hi @moskyb - wondering if I could get a review on this to see if it is worth continuing to pursue? |
|
i was literally just coming here to look for this, bump |
triarius
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
@wbond thanks for making this PR. And apologies for letting this one fall though the cracks.
This looks like a great thing to have, and the code looks fine. Unfortunately, the CI for this repo has atrophied, so bear with us while we make a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help fleets where instance startup time is slow, by allowing them to configure enough free instances to handle a certain amount of load while new instances spin up.