-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new release process #97
Merged
triarius
merged 19 commits into
master
from
pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again
Aug 22, 2023
Merged
Create a new release process #97
triarius
merged 19 commits into
master
from
pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
force-pushed
the
pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again
branch
10 times, most recently
from
August 16, 2023 13:25
180b56d
to
fb0a72f
Compare
Emojis look cool, but they are a bit hard to interpret unambiguously.
triarius
force-pushed
the
pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again
branch
from
August 16, 2023 14:16
3d2ab3d
to
a1cf16b
Compare
triarius
force-pushed
the
pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again
branch
from
August 17, 2023 05:37
cc873f8
to
2e2c2c5
Compare
triarius
force-pushed
the
pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again
branch
from
August 17, 2023 05:44
8a6656d
to
3d91ca2
Compare
I'm going to merge this and iterate on the default branch to get the release process working again. |
triarius
deleted the
pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again
branch
August 22, 2023 05:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we conditionally uploaded steps that created a release on GitHub and uploaded the lambda to s3. Now, I've made those steps be conditional steps instead.
I've also moved the block step to be after the release on GitHub is created. The idea is that the release is just a draft. Once the draft is acceptable, the pipeline should be unblocked, pushing the lambda to s3. The same should be done for the SAR release pipeline, which needs different permissions, so lives in a different Buildkite organization. This second pipeline repeats some work from the main pipeline, so I would like to remove it eventually.
I have also changed the release step to read the CHANGELOG.md file and use the GitHub CLI instead of a custom tool use used to develop.
The new procedure is here: https://github.com/buildkite/buildkite-agent-scaler/blob/pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again/RELEASE.md