Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new release process #97

Merged

Conversation

triarius
Copy link
Contributor

@triarius triarius commented Aug 14, 2023

Previously, we conditionally uploaded steps that created a release on GitHub and uploaded the lambda to s3. Now, I've made those steps be conditional steps instead.

I've also moved the block step to be after the release on GitHub is created. The idea is that the release is just a draft. Once the draft is acceptable, the pipeline should be unblocked, pushing the lambda to s3. The same should be done for the SAR release pipeline, which needs different permissions, so lives in a different Buildkite organization. This second pipeline repeats some work from the main pipeline, so I would like to remove it eventually.

I have also changed the release step to read the CHANGELOG.md file and use the GitHub CLI instead of a custom tool use used to develop.

The new procedure is here: https://github.com/buildkite/buildkite-agent-scaler/blob/pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again/RELEASE.md

@triarius triarius force-pushed the pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again branch 10 times, most recently from 180b56d to fb0a72f Compare August 16, 2023 13:25
@triarius triarius force-pushed the pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again branch from 3d2ab3d to a1cf16b Compare August 16, 2023 14:16
@triarius triarius marked this pull request as ready for review August 16, 2023 23:30
@triarius triarius requested a review from a team August 16, 2023 23:30
@triarius triarius force-pushed the pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again branch from cc873f8 to 2e2c2c5 Compare August 17, 2023 05:37
@triarius triarius force-pushed the pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again branch from 8a6656d to 3d91ca2 Compare August 17, 2023 05:44
@triarius
Copy link
Contributor Author

I'm going to merge this and iterate on the default branch to get the release process working again.

@triarius triarius merged commit 1fdc40a into master Aug 22, 2023
@triarius triarius deleted the pdp-1449-makebuildkite-agent-scaler-be-published-to-s3-again branch August 22, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant