More configurability of fullname template variable #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide more ways to tailor the `fullname` template variable that is used for naming resources. It's a way to independently set it from the `name` template variable that is used in the `app` label and selector, which is useful when you want to have multiple Buildkite agents with different configuration deployed into the same Kubernetes namespace, but without having awkward resource names. See #99 for more details.
|
@rimusz Jarryd asked me to ping you here since you're the one that reviews the changes for this helm chart and currently there are no reviewers assigned. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Provide more ways to tailor the
fullnametemplate variable that is used for naming resources.It's a way to independently set it from the
nametemplate variable that is used in theapplabel and selector, which is useful when you want to have multiple Buildkite agents with different configuration deployed into the same Kubernetes namespace, but without having awkward resource names.See #99 for more details.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #fixes #99
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]