Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CpuCredits parameter #976

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheDen
Copy link

@TheDen TheDen commented Dec 17, 2021

PR Adds CreditSpecification in the AWS::EC2::LaunchTemplate LaunchTemplateData specification.

Defaulting to unlimited, but can be standard if it's a better default.

Comment on lines +942 to +943
CreditSpecification:
CpuCredits: !Ref CpuCredits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the docs say:

The credit option for CPU usage of the instance. Valid for T2, T3, or T3a instances only.

Will the presence of this option break the LaunchTemplate for other instance types?
Or are they happy [as long as it's set to unlimited?]?

Copy link
Author

@TheDen TheDen Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not certain about this either. I tried to test it locally but couldn't get it working. The docs seem out of date since It would also work for t4g graviton instances

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a cleaner solution would be to conditionally add the CreditSpecification YAML key+value if InstanceType matches one of the supported EC2 types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants