This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Update READMEs to make refs clearer #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giogonzo
reviewed
Jan 25, 2020
README.md
Outdated
| @@ -17,6 +17,9 @@ ReactDOM.renderComponent( | |||
| ``` | |||
| npm install --save react-autosize-textarea | |||
| ``` | |||
| ``` | |||
| yarn add --dev react-autosize-textarea | |||
There was a problem hiding this comment.
why --dev? Should be a "prod" dependency
There was a problem hiding this comment.
whoops, thanks @giogonzo - I'll remove that 🙂
Updated as part of v7
giogonzo
approved these changes
Jan 27, 2020
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change from using
innerRefto just usingref, I've opened this PR to make the docs a little clearer.