Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27: animation support (closes #27) #30

Merged
merged 6 commits into from
May 31, 2017
Merged

Conversation

FrancescoCioria
Copy link
Contributor

@FrancescoCioria FrancescoCioria commented May 28, 2017

Closes #27

Test Plan

tests performed

https://gyazo.com/08bbdc6c9cb0e3b6ac3f9f412a2d76b2

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.}

Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, although the build config could use some love :)

@FrancescoCioria
Copy link
Contributor Author

looks good, although the build config could use some love :)

I'm waiting for https://github.com/buildo/scriptoni :)

@FrancescoCioria FrancescoCioria merged commit ed11ea4 into master May 31, 2017
@nemobot
Copy link

nemobot commented May 31, 2017

@FrancescoCioria FrancescoCioria deleted the 27-animation_support branch May 31, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants