Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#69: Refactor in TypeScript (closes #69) #70

Merged
merged 1 commit into from
May 4, 2018

Conversation

FrancescoCioria
Copy link
Contributor

@FrancescoCioria FrancescoCioria commented May 4, 2018

Closes #69
Closes #67

Test Plan

tests performed

A Test Plan is used to show what you tested to make sure your code works fine. You should write here all that you did to test, and provide some results of your testing.

These results can be screenshots, query results, or even just pointers to unit tests that successfully passed.}

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.}

@nemobot
Copy link

nemobot commented May 4, 2018

@nemobot nemobot removed the WIP label May 4, 2018
@FrancescoCioria FrancescoCioria deleted the 69-refactor_in_typescript branch May 4, 2018 12:53
rows?: undefined,
color?: undefined,
showLoadingAnimation?: undefined
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use https://github.com/gcanti/prop-types-ts and avoid duplication, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants