Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sigstore/cosign dependency to v1.5.2 #924

Conversation

stormqueen1990
Copy link
Contributor

@stormqueen1990 stormqueen1990 commented Feb 17, 2022

Upgrade sigstore/cosign dependency from v1.0.0 to v1.5.2.

Fixes #923

Tasks:

  • Upgrade sigstore/cosign dependency.
  • Update code to conform to the new function signatures.
  • Check and fix code and tests if needed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #924 (e4118db) into main (9df4940) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   69.66%   69.74%   +0.07%     
==========================================
  Files         119      119              
  Lines        5364     5377      +13     
==========================================
+ Hits         3737     3750      +13     
  Misses       1265     1265              
  Partials      362      362              
Impacted Files Coverage Δ
pkg/cosign/image_signer.go 89.65% <100.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df4940...e4118db. Read the comment docs.

@stormqueen1990 stormqueen1990 changed the title Upgrade sigstore/cosign dependency to v1.5.1 Upgrade sigstore/cosign dependency to v1.5.2 Mar 1, 2022
@stormqueen1990 stormqueen1990 marked this pull request as ready for review March 2, 2022 14:25
@tomkennedy513 tomkennedy513 self-requested a review March 3, 2022 15:58
github.com/google/go-cmp v0.5.7
github.com/google/go-containerregistry v0.8.0
github.com/google/go-containerregistry/pkg/authn/k8schain v0.0.0-20210610160139-c086c7f16d4e
github.com/google/go-containerregistry v0.8.1-0.20220125170349-50dfc2733d10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a released version of ggcr?

Copy link
Contributor Author

@stormqueen1990 stormqueen1990 Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the replace directive on line 46 take care of that, perhaps? If I recall correctly the project does not build with this version but it is a transitive dependency of the version upgrade.

go.mod Show resolved Hide resolved
* Upgrade sigstore/cosign dependency to v1.5.2.
* Lock version of Kubernetes libraries to v0.20.11.
@tylerphelan tylerphelan merged commit 465e706 into buildpacks-community:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade sigstore/cosign dependency version
5 participants