Removes platform/launcher contract from buildpack API spec #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description of the interpretation of launcher arguments belongs in the platform API because it the contract being described is between the platform and the lifecycle. In the buildpack API spec we should exclusively specify how buildpack provided outputs interact with the launch process. Signed-off-by: Emily Casey <[email protected]>
jkutner
approved these changes
Jul 6, 2020
nebhale
approved these changes
Jul 6, 2020
nebhale
approved these changes
Jul 6, 2020
sclevine
approved these changes
Jul 7, 2020
AidanDelaney
added a commit
that referenced
this pull request
Dec 19, 2022
RFC #109 defines a directory allowing operators to set environment variables for detect and build phases. Specify how the buildpack phases should implement the behavior. Signed-off-by: Aidan Delaney <[email protected]>
AidanDelaney
added a commit
that referenced
this pull request
Dec 19, 2022
RFC #109 defines a directory allowing operators to set environment variables for detect and build phases. Specify how the buildpack phases should implement the behavior. Signed-off-by: Aidan Delaney <[email protected]>
AidanDelaney
added a commit
that referenced
this pull request
Jan 17, 2023
RFC #109 defines a directory allowing operators to set environment variables for detect and build phases. Specify how the buildpack phases should implement the behavior. Signed-off-by: Aidan Delaney <[email protected]>
jjbustamante
pushed a commit
to jjbustamante/cnb-spec
that referenced
this pull request
Mar 27, 2023
RFC buildpacks#109 defines a directory allowing operators to set environment variables for detect and build phases. Specify how the buildpack phases should implement the behavior. Signed-off-by: Aidan Delaney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the interpretation of launcher arguments belongs in the platform API because it the contract being described is between the platform and the lifecycle. In the buildpack API spec we should exclusively specify how buildpack provided outputs interact with the launch process.
Signed-off-by: Emily Casey [email protected]