Buildpack API in group and metadata #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebhale
approved these changes
Jul 28, 2020
hone
approved these changes
Jul 28, 2020
|
@ekcasey I added this to the platform 0.4 milestone. |
sclevine
requested changes
Jul 30, 2020
jkutner
approved these changes
Jul 30, 2020
Now that we have buidpack API dependent launch logic, the launcher needs the api of each buildpack to exist in metadata.toml so it can do the right thing * See #116 for an example (arg parsing for direct=false processes) Other phases may have buidpack API dependent logic as well. Adding the `api` to group.toml will provide this the api of each buildpack everywhere it is needed. Signed-off-by: Emily Casey <[email protected]>
Signed-off-by: Emily Casey <[email protected]> Co-authored-by: Stephen Levine <[email protected]>
ekcasey
force-pushed
the
buildpack-api-in-group-and-metadata
branch
from
c0ac758
to
f801a88
Compare
sclevine
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have buidpack API dependent launch logic, the launcher needs the api of each buildpack to exist in metadata.toml so it can do the right thing
Other phases may have buidpack API dependent logic as well. Adding the
apito group.toml will provide this the api of each buildpack everywhere it is needed.Signed-off-by: Emily Casey [email protected]