Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism for platform to provide image creation time #292

Merged
merged 3 commits into from
Mar 30, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion platform.md
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@ Usage:
| `<stack>` | `CNB_STACK_PATH` | `/cnb/stack.toml` | Path to stack file (see [`stack.toml`](#stacktoml-toml)
| `<uid>` | `CNB_USER_ID` | | UID of the build image `User`
| `<layers>/config/metadata.toml` | | | Build metadata (see [`metadata.toml`](#metadatatoml-toml)
| | `SOURCE_DATE_EPOCH` | | Timestamp for `created` time in app image config |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though other variables used to configure the lifecycle start with CNB_ it seems better keep the interface consistent with other tooling (see under "Reading the variable" here).


- At least one `<image>` must be provided
- Each `<image>` MUST be a valid tag reference
Expand Down Expand Up @@ -601,7 +602,7 @@ Usage:
- `io.buildpacks.build.metadata`: see [build metadata](#iobuildpacksbuildmetadata-json)
- To ensure [build reproducibility](#build-reproducibility), the lifecycle:
- SHOULD set the modification time of all files in newly created layers to a constant value
- SHOULD set the `created` time in image config to a constant value
- SHOULD set the `created` time in image config to `SOURCE_DATE_EPOCH`, or to a constant value if not defined

- The lifecycle SHALL write a [report](#reporttoml-toml) to `<report>` describing the exported app image

Expand Down