Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder spec #363

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

joe-kimmel-vmw
Copy link
Contributor

No description provided.

@joe-kimmel-vmw joe-kimmel-vmw requested a review from a team as a code owner June 26, 2023 17:24
@@ -15,11 +15,12 @@ This document specifies the artifact format, delivery mechanism, and order resol

## Distribution API Version

This document specifies Distribution API version `0.3`.
This document specifies Distribution API version `0.4`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed stacks from the labels below so I think that justifies bumping the spec version? but I left them in the builder.toml spec as a backwards compat. option for older platform APIs.

distribution.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Kutner <[email protected]>
Signed-off-by: Joe Kimmel <[email protected]>
distribution.md Outdated Show resolved Hide resolved
distribution.md Outdated Show resolved Hide resolved
distribution.md Outdated Show resolved Hide resolved
distribution.md Outdated Show resolved Hide resolved
distribution.md Outdated

A platform supporting builders SHOULD allow users to configure the build environment for a provided builder.

A platform supporting builder creation MUST be able to create a valid builder from a valid builder.toml file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, this is good. can we link to the section below? Also, not sure how to say but we don't need to require that the file be named builder.toml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool - i mighta got just a little cheeky and dropped in a note about roses, but i gave a link so anyone who didn't previously read shakespeare could pick up the reference. lmk if that's too informal for the spec, I can tone it back down to corporate beige.

@joe-kimmel-vmw joe-kimmel-vmw changed the title first draft of builder spec builder spec Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants