[WG 2018-09-11] Relax specification for buildpack and stack IDs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebhale
reviewed
Sep 18, 2018
nebhale
reviewed
Sep 18, 2018
nebhale
suggested changes
Oct 17, 2018
nebhale
approved these changes
Oct 17, 2018
buildpack.md
Outdated
| The buildpack ID: | ||
| - MUST only contain numbers, letters, and the charactors `.`, `/`, and `-`. | ||
| - MUST NOT be `config` or `app`. | ||
| - MUST NOT be identical to any other buildpack ID when letters in each ID are converted to lower case. |
There was a problem hiding this comment.
Should this be described as "MUST NOT be identical to any other buildpack ID when using a case-insensitive comparison"?
buildpack.md
Outdated
|
|
||
| The stack ID: | ||
| - MUST only contain numbers, letters, and the charactors `.`, `/`, and `-`. | ||
| - MUST NOT be identical to any other stack ID when letters in each ID are converted to lower case. |
There was a problem hiding this comment.
Should this be described as "MUST NOT be identical to any other stack ID when using a case-insensitive comparison"?
|
@sclevine sorry so slow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.